Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update support to lts node #86

Merged
merged 2 commits into from
May 8, 2019
Merged

Update support to lts node #86

merged 2 commits into from
May 8, 2019

Conversation

rramo012
Copy link
Member

@rramo012 rramo012 commented May 8, 2019

The two main issues I kept seeing from with gulp and the latest node version is upath > 1.1.0 and natives > 1.1.6.

Updating the following dependency allows you to run the build on the latest node version without updating gulp to version 4.

@rramo012 rramo012 self-assigned this May 8, 2019
@rramo012 rramo012 requested a review from timelsass May 8, 2019 16:58
@timelsass
Copy link
Member

That's funny, I was looking into that yesterday, but yeah it's the natives package. I had never seen the resolutions field used, but that would fix the issue I was running into by just bumping natives up alone, thanks! 👍

@timelsass timelsass merged commit 1b9ec11 into dev May 8, 2019
@timelsass timelsass deleted the update/node-support branch May 8, 2019 17:29
@rramo012
Copy link
Member Author

rramo012 commented May 8, 2019

Neither did I. See: gulpjs/gulp#2162

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants